Skip to content

fix(actions): a failed server action no longer reports as success (green toast) - #2963

Merged
os-zhuang merged 1 commit into
mainfrom
claude/global-actions-unreachable-rw7hpk
Jul 29, 2026
Merged

fix(actions): a failed server action no longer reports as success (green toast)#2963
os-zhuang merged 1 commit into
mainfrom
claude/global-actions-unreachable-rw7hpk

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Companion to objectstack-ai/objectstack#3913 (server fix: objectstack-ai/objectstack#3930). The issue names this side explicitly — "the shipped console does exactly that on its main action path… so global-action failures produce a green success toast".

The hole

useConsoleActionRuntime.serverActionHandler — the console's main action path (list toolbars, row actions, page actions) — decided success from res.ok and the OUTER envelope only:

if (!res.ok || (json && json.success === false)) { /* failure */ }

A server older than objectstack#3913 reports a handler failure as HTTP 200 with the failure nested one level down:

{"success":true,"data":{"success":false,"error":"Action 'log_call' on object '*' not found"}}

Both guards pass. The action was reported as completed: the ActionRunner fired its green "completed" toast, the list refreshed, and the real error was swallowed.

RecordDetailView's copy of the same handler already inspected the inner envelope — this brings the shared runtime to parity, plus marketplaceApi.installPackage, which had the identical hole and could report a package as installed when it was not.

Current servers answer a failed action with a real HTTP status, which !res.ok catches first. The inner-envelope check is what keeps the console honest against a runtime that has not been upgraded yet — worth keeping, not a transitional shim.

Second defect this surfaced

With objectstack#3913 the failure body is {success: false, error: {message, code}}. RecordDetailView read json?.error raw:

const errMsg = (innerFailed && inner.error) || json?.error || `Action "${targetName}" failed (HTTP ${res.status})`;

That hands an object to toast.error() as a React child and crashes the page (React #31) — the exact failure useConsoleActionRuntime's local errorDetail helper was written to prevent. The helper is now a shared util (utils/actionErrorDetail) and both call sites go through it, so a nested {message} always resolves to a string.

Testing

  • Full app-shell suite: 1918 passed (232 files).
  • type-check clean; eslint 0 errors on the changed files.
  • 3 new cases in useConsoleActionRuntime.test.tsx: the inner-success:false failure, the nested {error:{message}} → string resolution, and a success guard so the new check can't turn a good action into a failure.
  • Verified the inner-envelope test is meaningful: with the || innerFailed guard removed it fails, and passes with it.

🤖 Generated with Claude Code

https://claude.ai/code/session_011AvZj6cLX7APd7roh2eK4F


Generated by Claude Code

…een toast)

objectstack#3913. `useConsoleActionRuntime.serverActionHandler` — the console's
main action path (list toolbars, row actions, page actions) — decided success
from `res.ok` and the OUTER envelope only. A server older than objectstack#3913
reports a handler failure as HTTP 200 with the failure nested one level down:

  {"success":true,"data":{"success":false,"error":"Action '…' not found"}}

Both guards pass, so the action was reported as completed: the ActionRunner
fired its green "completed" toast, the list refreshed, and the real error was
swallowed. RecordDetailView's copy of the handler already inspected the inner
envelope; the shared runtime now does too, as does marketplaceApi.installPackage,
which had the identical hole and could report a package as installed when it was
not.

Current servers answer a failed action with a real HTTP status, which `!res.ok`
catches first — the inner-envelope check is what keeps the console honest
against a runtime that has not been upgraded yet.

Also: with objectstack#3913 the failure body is {success:false, error:{message,
code}}. RecordDetailView read `json?.error` raw and would have handed that
OBJECT to toast.error() as a React child, crashing the page (React #31) — the
exact failure the runtime's `errorDetail` helper existed to prevent. That helper
is now a shared util (utils/actionErrorDetail) and both call sites use it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011AvZj6cLX7APd7roh2eK4F
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 29, 2026 10:49am

Request Review

@github-actions github-actions Bot added the tests label Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-Df7wYueN.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.25KB 1.01KB
auth (org-roles.js) 6.72KB 2.85KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.02KB 97.88KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 129.13KB 32.55KB
fields (index.js) 220.19KB 53.95KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 57.26KB 16.24KB
plugin-chatbot (index.js) 179.93KB 42.67KB
plugin-dashboard (index.js) 109.60KB 28.33KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 216.93KB 53.05KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.32KB 25.08KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 179.35KB 46.97KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.19KB 23.17KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.07KB 9.81KB
plugin-timeline (index.js) 25.03KB 7.11KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.47KB 20.82KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.00KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.86KB 0.91KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants